pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedneed xmllint on borka
6+ messages / 3 participants
[nested] [flat]
* need xmllint on borka
@ 2014-05-02 02:05 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 2 replies; 6+ messages in thread
From: Peter Eisentraut @ 2014-05-02 02:05 UTC (permalink / raw)
To: pgsql-hackers
I have been working on making the DocBook XML output valid. The first
part was bb4eefe7bf518e42c73797ea37b033a5d8a8e70a, I now have the rest
ready, but I'll spare you the mostly mechanical 200kB patch for now. In
addition, I'd like to add the attached patch with an xmllint call to
make sure things stay valid.
But we don't have xmllint installed on borka, where we build the
releases. Could someone please install it?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
xmllint.patch (text/x-patch, 879B) download
--- a/doc/src/sgml/Makefile
+++ b/doc/src/sgml/Makefile
@@ -76,6 +76,7 @@ override SPFLAGS += -wall -wno-unused-param -wno-empty -wfully-tagged
man distprep-man: man-stamp
man-stamp: stylesheet-man.xsl postgres.xml
+ $(XMLLINT) --noout --valid postgres.xml
$(XSLTPROC) $(XSLTPROCFLAGS) $(XSLTPROC_MAN_FLAGS) $^
touch $@
@@ -252,11 +253,13 @@ endif
xslthtml: xslthtml-stamp
xslthtml-stamp: stylesheet.xsl postgres.xml
+ $(XMLLINT) --noout --valid postgres.xml
$(XSLTPROC) $(XSLTPROCFLAGS) $(XSLTPROC_HTML_FLAGS) $^
cp $(srcdir)/stylesheet.css html/
touch $@
htmlhelp: stylesheet-hh.xsl postgres.xml
+ $(XMLLINT) --noout --valid postgres.xml
$(XSLTPROC) $(XSLTPROCFLAGS) $^
%-A4.fo.tmp: stylesheet-fo.xsl %.xml
@@ -279,6 +282,7 @@ XMLLINT = xmllint
epub: postgres.epub
postgres.epub: postgres.xml
+ $(XMLLINT) --noout --valid $<
$(DBTOEPUB) $<
* Re: need xmllint on borka
@ 2014-05-02 02:51 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter_e@gmx.net>
1 sibling, 2 replies; 6+ messages in thread
From: Tom Lane @ 2014-05-02 02:51 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> I have been working on making the DocBook XML output valid. The first
> part was bb4eefe7bf518e42c73797ea37b033a5d8a8e70a, I now have the rest
> ready, but I'll spare you the mostly mechanical 200kB patch for now. In
> addition, I'd like to add the attached patch with an xmllint call to
> make sure things stay valid.
> But we don't have xmllint installed on borka, where we build the
> releases. Could someone please install it?
-1. Doesn't this break "make man" for *any* hacker who doesn't have
xmllint installed?
Please change the patch so that it runs xmllint if available, rather
than turning it into a de facto requirement for anybody who works on
documentation. Or if you think you can pass a vote to require it,
I'd suggest that the patch had better include documentation additions
listing this as a required build tool.
(The subtext here is that borka is absolutely not an acceptable place
to encounter documentation build failures. By the time we're at that
stage of the release cycle, I don't really care what xmllint might
have to say; there isn't going to be time to make it happy.)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: need xmllint on borka
@ 2014-05-02 14:38 Alvaro Herrera <alvherre@2ndquadrant.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 6+ messages in thread
From: Alvaro Herrera @ 2014-05-02 14:38 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter_e@gmx.net>; pgsql-hackers
Tom Lane wrote:
> (The subtext here is that borka is absolutely not an acceptable place
> to encounter documentation build failures. By the time we're at that
> stage of the release cycle, I don't really care what xmllint might
> have to say; there isn't going to be time to make it happy.)
Borka is what runs the guaibasaurus animal, so failures would show up in
buildfarm ...
If the xmllint check could be made optional, I guess we could have the
failures show up in buildfarm but avoid having them cause a problem for
"make dist" when releases are created.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: need xmllint on borka
@ 2014-05-02 14:52 Alvaro Herrera <alvherre@2ndquadrant.com>
parent: Peter Eisentraut <peter_e@gmx.net>
1 sibling, 0 replies; 6+ messages in thread
From: Alvaro Herrera @ 2014-05-02 14:52 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-hackers
Peter Eisentraut wrote:
> I have been working on making the DocBook XML output valid. The first
> part was bb4eefe7bf518e42c73797ea37b033a5d8a8e70a, I now have the rest
> ready, but I'll spare you the mostly mechanical 200kB patch for now. In
> addition, I'd like to add the attached patch with an xmllint call to
> make sure things stay valid.
>
> But we don't have xmllint installed on borka, where we build the
> releases. Could someone please install it?
xmllint installed on borka.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: need xmllint on borka
@ 2014-05-07 02:20 Peter Eisentraut <peter_e@gmx.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2014-05-07 02:20 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers
On Thu, 2014-05-01 at 22:51 -0400, Tom Lane wrote:
> > But we don't have xmllint installed on borka, where we build the
> > releases. Could someone please install it?
>
> -1. Doesn't this break "make man" for *any* hacker who doesn't have
> xmllint installed?
>
> Please change the patch so that it runs xmllint if available, rather
> than turning it into a de facto requirement for anybody who works on
> documentation.
The intention is that we enforce that the documentation is correctly
formatted. Enforcing that only when the required tool is installed is
the same as not enforcing it and annoying those who happen to have the
tool installed.
> Or if you think you can pass a vote to require it,
> I'd suggest that the patch had better include documentation additions
> listing this as a required build tool.
Agreed. I have committed the SGML changes that make things valid now,
but I will postpone the xmllint addition until the 9.5 branch, complete
with more documentation.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: need xmllint on borka
@ 2014-05-07 03:22 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2014-05-07 03:22 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On Thu, 2014-05-01 at 22:51 -0400, Tom Lane wrote:
>> -1. Doesn't this break "make man" for *any* hacker who doesn't have
>> xmllint installed?
> The intention is that we enforce that the documentation is correctly
> formatted. Enforcing that only when the required tool is installed is
> the same as not enforcing it and annoying those who happen to have the
> tool installed.
Okay, but if that's the intent I suggest that the check needs to happen
somewhere more prominent than in nondefault build targets. Personally,
I run "make man" about once a release cycle, if that often; and I'm not
sure I've ever built any of the other targets modified in this patch.
If you want to enforce correctness then I think you should put the xmllint
call into the "make all" path, which would render all of the targets
touched here rather redundant.
Also, in the vein of "is this a full-scale build requirement or not",
why is the pathname of xmllint just hard-coded into the makefile and
not something that's checked for by configure?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2014-05-07 03:22 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2014-05-02 02:05 need xmllint on borka Peter Eisentraut <peter_e@gmx.net>
2014-05-02 02:51 ` Tom Lane <tgl@sss.pgh.pa.us>
2014-05-02 14:38 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2014-05-07 02:20 ` Peter Eisentraut <peter_e@gmx.net>
2014-05-07 03:22 ` Tom Lane <tgl@sss.pgh.pa.us>
2014-05-02 14:52 ` Alvaro Herrera <alvherre@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox