From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Joshua D. Drake <jd@commandprompt.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Simon Riggs <simon@2ndQuadrant.com>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: pgsql-core <pgsql-core@postgresql.org>
Subject: Re: [CORE] Restore-reliability mode
Date: Sun, 7 Jun 2015 00:07:31 -0300
Message-ID: <20150607030731.GD133018@postgresql.org> (raw)
In-Reply-To: <5573261E.6070500@commandprompt.com>
References: <20150530204727.GJ13944@alap3.anarazel.de>
<20150531024845.GB13697@momjian.us>
<20150603135049.GA74753@tornado.leadboat.com>
<WM!4ae914f9770e3cb63aa899dbc2db60d7ff4a3ad580e90f3dc1cd72315fff26fd1935dbe8884fd2e9f5370d881036c3bd!@asav-3.01.com>
<556F3798.6010707@agliodbs.com>
<CANP8+jJPyQLadtqrPJKrBVOEvK85nz+2oMk=CDAcUrwS-O-eNA@mail.gmail.com>
<20150605150514.GA25537@momjian.us>
<CANP8+jJd+7hncAmHUZCETxSPf0Ef9uKh227LBK4xSA9p1k0AYw@mail.gmail.com>
<20150606030708.GA31950@momjian.us>
<5573261E.6070500@commandprompt.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Joshua D. Drake wrote:
>
> On 06/05/2015 08:07 PM, Bruce Momjian wrote:
>
> >> From my side, it is only recently I got some clear answers to my questions
> >>about how it worked. I think it is very important that major features have
> >>extensive README type documentation with them so the underlying principles used
> >>in the development are clear. I would define the measure of a good feature as
> >>whether another committer can read the code comments and get a good feel. A bad
> >>feature is one where committers walk away from it, saying I don't really get it
> >>and I can't read an explanation of why it does that. Tom's most significant
> >>contribution is his long descriptive comments on what the problem is that need
> >>to be solved, the options and the method chosen. Clarity of thought is what
> >>solves bugs.
> >
> >Yes, I think we should have done that early-on for multi-xact, and I am
> >hopeful we will learn to do that more often when complex features are
> >implemented, or when we identify areas that are more complex than we
> >thought.
>
> I see this idea of the README as very useful. There are far more people like
> me in this community than Simon or Alvaro. I can test, I can break things, I
> can script up a harness but I need to be understand HOW and the README would
> help allow for that.
There is a src/backend/access/README.tuplock that attempts to describe
multixacts. Is that not sufficient?
Now that I think about it, this file hasn't been updated with the latest
changes, so it's probably a bit outdated now.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, jd@commandprompt.com, bruce@momjian.us, simon@2ndQuadrant.com, josh@agliodbs.com, noah@leadboat.com, andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, magnus@hagander.net, pgsql-core@postgresql.org
Subject: Re: [CORE] Restore-reliability mode
In-Reply-To: <20150607030731.GD133018@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox