pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Mon, 20 Mar 2017 12:40:58 -0400
Message-ID: <20170320164058.GT9812@tamriel.snowman.net> (raw)
In-Reply-To: <2509e5e9-4de2-1846-ddd0-6964f81d6c8b@lab.ntt.co.jp>
References: <7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp>
<20170217133251.GK9812@tamriel.snowman.net>
<2509e5e9-4de2-1846-ddd0-6964f81d6c8b@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Amit,
* Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> On 2017/02/17 22:32, Stephen Frost wrote:
> > * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> >> In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER TABLE
> >> command for those schema elements of a table that could not be included
> >> directly in the CREATE TABLE command for the table.
> >
> > Any chance we could start adding regression tests for how pg_dump
> > handles partitions? I'm just about to the point where I have pretty
> > much everything else covered (at least in pg_dump.c, where it's not a
> > hard-to-reproduce error/exit case, or something version-dependent).
> >
> > If you have any questions about how the TAP tests for pg_dump work, or
> > about how to generate code-coverage checks to make sure you're at least
> > hitting every line (tho, of course, not every possible path), let me
> > know. I'd be happy to explain them.
>
> Yeah, I guess it would be a good idea to have some pg_dump TAP test
> coverage for the new partitioning stuff. I will look into that and get
> back to you if I don't grok something there.
As you may have seen, I've added some tests to the pg_dump TAP tests for
partitioning to cover lines of code not already covered. There are
still some bits not covered though, which you can see here:
https://coverage.postgresql.org/src/bin/pg_dump/pg_dump.c.gcov.html
If you have any questions about the way the pg_dump tests work, feel
free to ask.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170320164058.GT9812@tamriel.snowman.net/2-signature.asc)
download
view thread (64+ messages) latest in thread
Message-ID: <20170320164058.GT9812@tamriel.snowman.net>
Permalink: ../20170320164058.GT9812@tamriel.snowman.net/
Also on: postgresql.org/message-id/20170320164058.GT9812@tamriel.snowman.net
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <20170320164058.GT9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox