From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: non-bulk inserts and tuple routing
Date: Thu, 22 Feb 2018 13:53:15 -0300
Message-ID: <20180222165315.k27qfn4goskhoswj@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoZYBc7HO6CfCTaksD40UyeM8+6_ShXs6XrYu5H0UC4SLQ@mail.gmail.com>
Robert Haas wrote:
> On Tue, Feb 20, 2018 at 8:06 PM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> >> Attached is an updated version for that.
> >
> > Thanks for updating the patch.
>
> Committed with a few changes.
I propose to tweak a few comments to PartitionTupleRouting, as attached.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:comments.patch (text/plain, 1.2K) downloaddiff --git a/src/include/executor/execPartition.h b/src/include/executor/execPartition.hindex e94718608f..08a994bce1 100644--- a/src/include/executor/execPartition.h+++ b/src/include/executor/execPartition.h@@ -58,11 +58,15 @@ typedef struct PartitionDispatchData *PartitionDispatch;
* partition tree.
* num_dispatch number of partitioned tables in the partition
* tree (= length of partition_dispatch_info[])
- * partition_oids Array of leaf partitions OIDs+ * partition_oids Array of leaf partitions OIDs with one entry+ * for every leaf partition in the partition tree,+ * initialized in full by+ * ExecSetupPartitionTupleRouting.
* partitions Array of ResultRelInfo* objects with one entry
- * for every leaf partition in the partition tree.+ * for every leaf partition in the partition tree,+ * initialized lazily.
* num_partitions Number of leaf partitions in the partition tree
- * (= 'partitions' array length)+ * (= 'partitions_oid'/'partitions' array length)
* parent_child_tupconv_maps Array of TupleConversionMap objects with one
* entry for every leaf partition (required to
* convert tuple from the root table's rowtype to
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, robertmhaas@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, fujita.etsuro@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org
Subject: Re: non-bulk inserts and tuple routing
In-Reply-To: <20180222165315.k27qfn4goskhoswj@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox