From: Michael Paquier <michael@paquier.xyz>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Date: Tue, 6 Mar 2018 10:32:00 +0900
Message-ID: <20180306013200.GG1878@paquier.xyz> (raw)
In-Reply-To: <CAFj8pRDp0uN3eS-zGMXGsdjceKcCd-GnfFMbbj7u6VERyRxKAQ@mail.gmail.com>
References: <20180111064900.GA51030@paquier.xyz>
<13647.1515685358@sss.pgh.pa.us>
<20180112012440.GA2222@paquier.xyz>
<20180220154656.GA7518@zakirov.localdomain>
<20180221073550.GA1632@paquier.xyz>
<CAFj8pRDp0uN3eS-zGMXGsdjceKcCd-GnfFMbbj7u6VERyRxKAQ@mail.gmail.com>
On Mon, Mar 05, 2018 at 09:25:09PM +0100, Pavel Stehule wrote:
> I afraid so there is not good solution. Is possible to store options in
> original form? When the function will be displayed, then the original value
> will be displayed. The current patch (with known extensions) can be used as
> bug fix and back patched. In new version we store original value with
> quotes.
You mean storing the values in pg_proc.proconfig at the creation time of
the function? That would basically work, except for the case of a
function using a parameter which is not from the same PL. The function
creation would fail because it cannot find the parameter it is looking
for as we need to look at loaded parameters to know it uses a list or
not :(
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, pavel.stehule@gmail.com, a.zakirov@postgrespro.ru, michael.paquier@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
In-Reply-To: <20180306013200.GG1878@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox