From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Date: Mon, 20 Aug 2018 11:37:49 +0900
Message-ID: <20180820023749.GD7403@paquier.xyz> (raw)
In-Reply-To: <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
<20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
<20180627230838.GI2667@paquier.xyz>
<9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
<920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
On Fri, Jul 13, 2018 at 11:05:10AM +0200, Peter Eisentraut wrote:
> After reviewing that thread, I think my patch would still be relevant.
> Because the pending proposal is to not add TOAST tables to some catalogs
> such as pg_attribute, so my original use case of allowing ALTER TABLE /
> SET on system catalogs would still be broken for those tables.
Something has happened in this area in the shape of 96cdeae, and the
following catalogs do not have toast tables: pg_class, pg_index,
pg_attribute and pg_largeobject*. While 0001 proposed upthread is not
really relevant anymore because there is already a test to list which
catalogs do not have a toast table. For 0002, indeed the patch is still
seems relevant. The comment block at the beginning of
create_toast_table should be updated. Some tests would also be nice to
have.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, andres@anarazel.de
Subject: Re: ALTER TABLE on system catalogs
In-Reply-To: <20180820023749.GD7403@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox