Re: file cloning in pg_upgrade and CREATE DATABASE

pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Date: Wed, 3 Oct 2018 08:32:48 +0900
Message-ID: <20181002233248.GA2609@paquier.xyz> (raw)
In-Reply-To: <45e10324-1bed-3936-70a0-b8859105ae39@2ndquadrant.com>
References: <20180323171650.GI1302@momjian.us>
	<4a62b089-ee93-50ee-f3f7-43c67b4c8ea4@2ndquadrant.com>
	<0241eae2-2f31-3667-200d-ae0e2293f692@2ndquadrant.com>
	<20180717065833.GG3388@paquier.xyz>
	<e15a6c65-267e-6328-734b-620fdf6772c2@2ndquadrant.com>
	<067fed44-db29-1334-3411-84b41959681a@2ndquadrant.com>
	<20180926064408.GL1659@paquier.xyz>
	<dcb1dc7a-eee0-efb0-673f-f235ef9e1005@2ndquadrant.com>
	<20180928051953.GH1500@paquier.xyz>
	<45e10324-1bed-3936-70a0-b8859105ae39@2ndquadrant.com>

On Tue, Oct 02, 2018 at 02:31:35PM +0200, Peter Eisentraut wrote:
> I can see the argument for that.  But I don't understand where the
> automatic mode fits into this.  I would like to keep all three modes
> from my patch: copy, clone-if-possible, clone-or-fail, unless you want
> to argue against that.

I'd like to argue against that :)

There could be an argument for having an automatic more within this
scheme, still I am not really a fan of this.  When somebody integrates
pg_upgrade within an upgrade framework, they would likely test if
cloning actually works, bumping immediately on a failure, no?  I'd like
to think that copy should be the default, cloning being available as an
option.  Cloning is not supported on many filesystems anyway..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (42+ messages)  latest in thread

Message-ID: <20181002233248.GA2609@paquier.xyz>
Permalink:  ../20181002233248.GA2609@paquier.xyz/
Also on:    postgresql.org/message-id/20181002233248.GA2609@paquier.xyz

 ·

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, bruce@momjian.us
  Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
  In-Reply-To: <20181002233248.GA2609@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox