pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Date: Mon, 10 Dec 2018 22:52:37 +0900
Message-ID: <20181210135237.GA1473@paquier.xyz> (raw)
In-Reply-To: <20181210132143.GJ3415@tamriel.snowman.net>
References: <20181207010406.GO2407@paquier.xyz>
	<20181207230540.GA12740@paquier.xyz>
	<6105.1544243612@sss.pgh.pa.us>
	<20181208065436.GC1989@paquier.xyz>
	<20181208134608.GY3415@tamriel.snowman.net>
	<20181208231507.GA1833@paquier.xyz>
	<20181208235926.GB1833@paquier.xyz>
	<20181209174917.GE3415@tamriel.snowman.net>
	<20181209224221.GB3710@paquier.xyz>
	<20181210132143.GJ3415@tamriel.snowman.net>

On Mon, Dec 10, 2018 at 08:21:43AM -0500, Stephen Frost wrote:
> * Michael Paquier (michael@paquier.xyz) wrote:
>> This still looks adapted to me.  Or would you reword it because "allow"
>> rather implies that an ERROR is returned?  Would you prefer changing it
>> something like that perhaps:
>> "Return NULL for relation types that do not appear in partition trees."
> 
> Yes.

OK.  Sure, let's do as you suggest then.  I'll wait a couple of days
before committing the patch so as if someone has extra comments they
have the time to post.  So please feel free to comment!
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20181210135237.GA1473@paquier.xyz/2-signature.asc)
  download

view thread (36+ messages)  latest in thread

Message-ID: <20181210135237.GA1473@paquier.xyz>
Permalink:  ../20181210135237.GA1473@paquier.xyz/
Also on:    postgresql.org/message-id/20181210135237.GA1473@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, sfrost@snowman.net, tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp
  Subject: Re: pg_partition_tree crashes for a non-defined relation
  In-Reply-To: <20181210135237.GA1473@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox