From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
Date: Fri, 1 Feb 2019 08:43:23 -0300
Message-ID: <201902011143.zzf7gxlxeszc@alvherre.pgsql> (raw)
In-Reply-To: <201902011133.t5pccj6jraqe@alvherre.pgsql>
On 2019-Feb-01, Alvaro Herrera wrote:
> ... so this code
>
> if (!ropt->noOwner)
> sanitized_owner = replace_line_endings(te->owner);
> else
> sanitized_owner = pg_strdup("-");
>
> can become
> sanitized_owner = replace_line_endings(te->owner, true);
Sorry, there's a silly bug here because I picked the wrong example to
hand-type. The proposed pattern works fine for the schema cases, not
for this owner case. The owner case is correctly handled (AFAICT) in
the patch I posted. (Also for some reason I decided to go with "hyphen"
instead of "dash" in the argument name. Not sure if anybody cares
strongly about using the right terminology there (I don't know which it
is).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, 9erthalion6@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, chap@anastigmatix.net, amitdkhan.pg@gmail.com
Subject: Re: ArchiveEntry optional arguments refactoring
In-Reply-To: <201902011143.zzf7gxlxeszc@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox