From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
Date: Tue, 12 Feb 2019 11:09:41 +0900
Message-ID: <20190212020941.GC1475@paquier.xyz> (raw)
In-Reply-To: <3e781ef4-04cb-5670-ee2b-7c0e99f72ece@lab.ntt.co.jp>
References: <16646.1549770618@sss.pgh.pa.us>
<E7790843-B885-492B-8537-CC9FB39D5F97@yesql.se>
<11413.1549835730@sss.pgh.pa.us>
<6f1657f9-c58c-ba28-0013-d36a6f6fd246@2ndquadrant.com>
<6418.1549895430@sss.pgh.pa.us>
<3e781ef4-04cb-5670-ee2b-7c0e99f72ece@lab.ntt.co.jp>
On Tue, Feb 12, 2019 at 10:29:40AM +0900, Amit Langote wrote:
> On 2019/02/11 23:30, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> Now that I see this in action, it makes the actual test results harder
>>> to identify flying by. I understand the desire to collect this timing
>>> data, but that is a special use case and not relevant to the normal use
>>> of the test suite, which is to see whether the test passes. Can we make
>>> this optional please?
>>
>> Well, I want the buildfarm to produce this info, so it's hard to see
>> how to get that without the timings being included by default. I take
>> your point that it makes the display look a bit cluttered, though.
>> Would it help to put more whitespace between the status and the timing?
>
> +1. Maybe, not as much whitespace as we get today between the test name
> and "... ok", but at least more than just a single space.
Sure, but do we need feedback immediately? I am just catching up on
that, and I too find a bit annoying that this is not controlled by a
switch which is disabled by default. It seems to me that this points
out to another issue that there is no actual way to pass down custom
options to pg_regress other than PG_REGRESS_DIFF_OPTS to control the
diff output format. So we may also want something like
PG_REGRESS_OPTS.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: Reporting script runtimes in pg_regress
In-Reply-To: <20190212020941.GC1475@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox