From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Donald Dong <xdong@csumb.edu>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Unified logging system for command-line programs
Date: Tue, 2 Apr 2019 16:56:34 -0300
Message-ID: <20190402195634.GA14682@alvherre.pgsql> (raw)
In-Reply-To: <c369a25e-ec9f-3b96-e765-75dd3a63e4c5@2ndquadrant.com>
I don't much like the code that does
pg_log_error("%s", something);
because then the string "%s" is marked for translation. Maybe we should
consider a variant that takes a straight string literal instead of a
sprintf-style fmt to avoid this problem. We'd do something like
pg_log_error_v(something);
which does not call _() within.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, xdong@csumb.edu, andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: Unified logging system for command-line programs
In-Reply-To: <20190402195634.GA14682@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox