From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Date: Wed, 17 Apr 2019 23:14:13 -0500
Message-ID: <20190418041413.GK2854@telsasoft.com> (raw)
In-Reply-To: <20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
References: <20190408002847.GA904@telsasoft.com>
<da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
<20190410165917.GD10080@telsasoft.com>
<20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
<20190418004219.GJ2854@telsasoft.com>
<20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.sgml
> > +++ b/doc/src/sgml/information_schema.sgml
> > @@ -1312,8 +1312,8 @@
> > <para>
> > The view <literal>columns</literal> contains information about all
> > table columns (or view columns) in the database. System columns
> > - (<literal>ctid</literal>, etc.) are not included. Only those columns are
> > - shown that the current user has access to (by way of being the
> > + (<literal>ctid</literal>, etc.) are not included. The only columns shown
> > + are those to which the current user has access (by way of being the
> > owner or having some privilege).
> > </para>
>
> I don't see the point of this change? Nor what it has to do with oids?
It doesn't have to do with oids, but seems more correct and cleaner...to my
eyes.
> > - <replaceable>rows</replaceable> was exactly one and the target table was
> > + <replaceable>count</replaceable> was exactly one and the target table was
> The <replacable>rows</<replacable> reference is from your change
> :(.
Ouch, not sure how I did that..sorry for the noise (twice).
Thanks,
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, daniel@manitou-mail.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
In-Reply-To: <20190418041413.GK2854@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox