pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedClonedConstraint typedef is dead code?
3+ messages / 2 participants
[nested] [flat]
* ClonedConstraint typedef is dead code?
@ 2019-05-15 19:05 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2019-05-15 19:05 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
catalog/pg_constraint.h defines a typedef ClonedConstraint,
which AFAICS is no longer referenced anywhere. Is there a
reason not to remove it?
(I noticed this while eyeballing a test pgindent run.)
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: ClonedConstraint typedef is dead code?
@ 2019-05-15 19:19 Alvaro Herrera <alvherre@2ndquadrant.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Alvaro Herrera @ 2019-05-15 19:19 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@lists.postgresql.org
On 2019-May-15, Tom Lane wrote:
> catalog/pg_constraint.h defines a typedef ClonedConstraint,
> which AFAICS is no longer referenced anywhere. Is there a
> reason not to remove it?
Oh, I didn't realize it had become completely unused! It was used for
FK creation in partitioned tables, but we rewrote that code completely
and I don't foresee needing that struct for anything in the future, so
it seems safe to remove.
Thanks,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: ClonedConstraint typedef is dead code?
@ 2019-05-15 21:27 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 0 replies; 3+ messages in thread
From: Tom Lane @ 2019-05-15 21:27 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: pgsql-hackers@lists.postgresql.org
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-May-15, Tom Lane wrote:
>> catalog/pg_constraint.h defines a typedef ClonedConstraint,
>> which AFAICS is no longer referenced anywhere. Is there a
>> reason not to remove it?
> Oh, I didn't realize it had become completely unused! It was used for
> FK creation in partitioned tables, but we rewrote that code completely
> and I don't foresee needing that struct for anything in the future, so
> it seems safe to remove.
Thanks, done.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-05-15 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 19:05 ClonedConstraint typedef is dead code? Tom Lane <tgl@sss.pgh.pa.us>
2019-05-15 19:19 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-05-15 21:27 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox