pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: ClonedConstraint typedef is dead code?
Date: Wed, 15 May 2019 15:19:40 -0400
Message-ID: <20190515191940.GA6777@alvherre.pgsql> (raw)
In-Reply-To: <18102.1557947143@sss.pgh.pa.us>

On 2019-May-15, Tom Lane wrote:

> catalog/pg_constraint.h defines a typedef ClonedConstraint,
> which AFAICS is no longer referenced anywhere.  Is there a
> reason not to remove it?

Oh, I didn't realize it had become completely unused!  It was used for
FK creation in partitioned tables, but we rewrote that code completely
and I don't foresee needing that struct for anything in the future, so
it seems safe to remove.

Thanks,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (3+ messages)  latest in thread

Message-ID: <20190515191940.GA6777@alvherre.pgsql>
Permalink:  ../20190515191940.GA6777@alvherre.pgsql/
Also on:    postgresql.org/message-id/20190515191940.GA6777@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: ClonedConstraint typedef is dead code?
  In-Reply-To: <20190515191940.GA6777@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox