From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Fetter <david@fetter.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v5] Show detailed table persistence in \dt+
Date: Tue, 2 Jul 2019 15:56:18 -0400
Message-ID: <20190702195618.GA28184@alvherre.pgsql> (raw)
In-Reply-To: <4561.1562094637@sss.pgh.pa.us>
On 2019-Jul-02, Tom Lane wrote:
> * The persistence description values ought to be translatable, as
> is the usual practice in describe.c. This is slightly painful
> because it requires tweaking the translate_columns[] values in a
> non-constant way, but it's not that bad.
LGTM. I only fear that the cols_so_far thing is easy to break, and the
breakage will be easy to miss.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, david@fetter.org, coelho@cri.ensmp.fr, rafia.pghackers@gmail.com
Subject: Re: [PATCH v5] Show detailed table persistence in \dt+
In-Reply-To: <20190702195618.GA28184@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox