From: Michael Paquier <michael@paquier.xyz>
To: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_receivewal documentation
Date: Fri, 19 Jul 2019 10:27:57 +0900
Message-ID: <20190719012757.GD1859@paquier.xyz> (raw)
In-Reply-To: <fd10372f-1cc9-3068-8088-c5da27a28bf7@redhat.com>
References: <20190716050555.GA1439@paquier.xyz>
<ebed4b9043b222d486ea3f0e44e7dcd242a80781.camel@cybertec.at>
<65c3ecdf-8995-34cb-83c4-50068877e632@redhat.com>
<20190717013835.GA2130@paquier.xyz>
<44e51f9f60abb872854879c91da0ed3b67a6ba95.camel@cybertec.at>
<20190717080424.GB20614@paquier.xyz>
<7eaf748c-3f40-c994-0eb3-7d87709588d0@redhat.com>
<184780f1f90a31c4c8b53f0e6328bf5aaae4f786.camel@cybertec.at>
<20190718052909.GF1416@paquier.xyz>
<fd10372f-1cc9-3068-8088-c5da27a28bf7@redhat.com>
On Thu, Jul 18, 2019 at 08:40:36AM -0400, Jesper Pedersen wrote:
> On 7/18/19 1:29 AM, Michael Paquier wrote:
>> Or more simply like that?
>> "Note that while WAL will be flushed with this setting,
>> pg_receivewal never applies it, so synchronous_commit must not be set
>> to remote_apply if pg_receivewal is a synchronous standby, be it a
>> member of a priority-based (FIRST) or a quorum-based (ANY) synchronous
>> replication setup."
>
> Yeah, better.
I was looking into committing that, and the part about
synchronous_commit = on is not right. The location of the warning is
also harder to catch for the reader, so instead let's move it to the
top where we have an extra description for --synchronous. I am
finishing with the attached that I would be fine to commit and
back-patch as needed. Does that sound fine?
--
Michael
Attachments:receivewal-apply-doc.patch (text/x-diff, 1.0K) downloaddiff --git a/doc/src/sgml/ref/pg_receivewal.sgml b/doc/src/sgml/ref/pg_receivewal.sgmlindex 0506120c00..3670e9c6f9 100644--- a/doc/src/sgml/ref/pg_receivewal.sgml+++ b/doc/src/sgml/ref/pg_receivewal.sgml@@ -52,7 +52,14 @@ PostgreSQL documentation
Unlike the WAL receiver of a PostgreSQL standby server, <application>pg_receivewal</application>
by default flushes WAL data only when a WAL file is closed.
The option <option>--synchronous</option> must be specified to flush WAL data
- in real time.+ in real time. Note that while WAL will be flushed with this setting,+ <application>pg_receivewal</application> never applies WAL, so+ <xref linkend="guc-synchronous-commit"/> must not be set to+ <literal>remote_apply</literal> if+ <application>pg_receivewal</application> is a synchronous standby,+ be it a member of a priority-based (<literal>FIRST</literal>) or a+ quorum-based (<literal>ANY</literal>) synchronous replication setup+ as set in <xref linkend="guc-synchronous-standby-names"/>.
</para>
<para>
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, jesper.pedersen@redhat.com, laurenz.albe@cybertec.at, alvherre@2ndquadrant.com
Subject: Re: pg_receivewal documentation
In-Reply-To: <20190719012757.GD1859@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox