From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
Date: Mon, 9 Sep 2019 08:35:59 +0900
Message-ID: <20190908233559.GA2467@paquier.xyz> (raw)
In-Reply-To: <18363.1567981113@sss.pgh.pa.us>
References: <6628.1567958876@sss.pgh.pa.us>
<5e1113b9-e1a6-d68b-c05c-06e607a4cd5f@2ndQuadrant.com>
<17551.1567979940@sss.pgh.pa.us>
<688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com>
<18363.1567981113@sss.pgh.pa.us>
On Sun, Sep 08, 2019 at 06:18:33PM -0400, Tom Lane wrote:
> Sure, I saw that you can run one test that way ... but what do you
> do when you want the equivalent of check-world?
I think that it is a good idea to add in subdircheck an extra path to
check after TAP tests and run optionally these on top of the normal
regression tests. I have a couple of comments.
+ # Look for TAP tests.
+ if ($config->{tap_tests} && -d "t")
+ {
+ print
"============================================================\n";
+ print "Running $module TAP tests\n";
+ my $status = tap_check(getcwd());
+ $mstat ||= $status;
+ }
Shouldn't we check after TAP_TESTS in the Makefile?
There is an argument to also check after isolation tests and run
them. It seems to me that we should check after ISOLATION, and run
optionally the tests if there is anything present. So we need
something like fetchTests() and fetchRegressOpts() but for isolation
tests.
The glob() part is a good idea in itself I think. Why not
back-patching it? I could double-check it as well.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests
In-Reply-To: <20190908233559.GA2467@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox