From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date: Tue, 17 Sep 2019 13:06:18 +0900
Message-ID: <20190917040618.GD1660@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1LQsGOLkvpcK8_SQs6yVGriv_yuwQPh69=3c5C_Vd8MgQ@mail.gmail.com>
References: <20190916134056.GB6026@paquier.xyz>
<20190916141106.GA10690@alvherre.pgsql>
<20190917004417.GA1660@paquier.xyz>
<CAA4eK1LQsGOLkvpcK8_SQs6yVGriv_yuwQPh69=3c5C_Vd8MgQ@mail.gmail.com>
On Tue, Sep 17, 2019 at 09:23:45AM +0530, Amit Kapila wrote:
> We always return a single tuple/record from this function, so do we
> really need to return SETOF record or just returning record is
> sufficient?
Right (with the doc update).
> If you want to use the same size array, then you might want to just
> memset the previous array rather than first freeing it and then again
> allocating it. This is not a big point, so any which way is fine.
Sure. This is less expensive though, so changed it the way you
are suggesting on my local branch.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190917040618.GD1660@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, amit.kapila16@gmail.com, alvherre@2ndquadrant.com, sawada.mshk@gmail.com, craig@2ndquadrant.com, ashu.coek88@gmail.com, rjuju123@gmail.com, pg@bowt.ie, ams@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, pavan.deolasee@2ndquadrant.com
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
In-Reply-To: <20190917040618.GD1660@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox