From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <v.wagner@postgrespro.ru>
Subject: Re: pg_upgrade check fails on Solaris 10
Date: Wed, 18 Sep 2019 11:36:00 -0300
Message-ID: <20190918143600.GA4211@alvherre.pgsql> (raw)
In-Reply-To: <feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru>
On 2019-Sep-17, Marina Polyakova wrote:
> Hello, hackers!
>
> We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
> argument to the sed command is not enclosed in quotation marks (see [1]):
Hmm, I'm surprised it has taken this long to detect the problem.
> Attached diff.patch fixes the problem.
I have pushed it to all branches that have src/bin/pg_upgrade (namely,
9.5 onwards), thanks. I hope this won't make the msys/mingw machines
angry ;-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, m.polyakova@postgrespro.ru, v.wagner@postgrespro.ru
Subject: Re: pg_upgrade check fails on Solaris 10
In-Reply-To: <20190918143600.GA4211@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox