From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Paul Jungwirth <pj@illuminatedcomputing.com>
Subject: Re: useless RangeIOData->typiofunc
Date: Thu, 5 Mar 2020 12:02:40 -0300
Message-ID: <20200305150240.GA8064@alvherre.pgsql> (raw)
In-Reply-To: <462.1583418414@sss.pgh.pa.us>
On 2020-Mar-05, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> > typioparam too:
>
> > typedef struct RangeIOData
> > {
> > TypeCacheEntry *typcache; /* range type's typcache entry */
> > FmgrInfo proc; /* element type's I/O function */
> > Oid typioparam; /* element type's I/O parameter */
> > } RangeIOData;
>
> Yeah, WFM. Maybe even rename the FmgrInfo to "typioproc"
> or the like?
Good idea, thanks! Pushed with that change.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pj@illuminatedcomputing.com
Subject: Re: useless RangeIOData->typiofunc
In-Reply-To: <20200305150240.GA8064@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox