From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Paul Jungwirth <pj@illuminatedcomputing.com>
Subject: Re: useless RangeIOData->typiofunc
Date: Thu, 05 Mar 2020 09:26:54 -0500
Message-ID: <462.1583418414@sss.pgh.pa.us> (raw)
In-Reply-To: <20200305141859.GA6736@alvherre.pgsql>
References: <20200305141859.GA6736@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> typioparam too:
> typedef struct RangeIOData
> {
> TypeCacheEntry *typcache; /* range type's typcache entry */
> FmgrInfo proc; /* element type's I/O function */
> Oid typioparam; /* element type's I/O parameter */
> } RangeIOData;
Yeah, WFM. Maybe even rename the FmgrInfo to "typioproc"
or the like?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, pj@illuminatedcomputing.com
Subject: Re: useless RangeIOData->typiofunc
In-Reply-To: <462.1583418414@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox