pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: error context for vacuum to include block number
Date: Mon, 23 Mar 2020 23:16:16 -0500
Message-ID: <20200324041616.GA21443@telsasoft.com> (raw)
In-Reply-To: <CAA4eK1KaWto3+4+EsLPRFL6HKs8=_42V2ivAFEPBU-o_o6AYXw@mail.gmail.com>
References: <20200319202931.GT26184@telsasoft.com>
	<20200320002909.GU26184@telsasoft.com>
	<CAA4eK1L_FWiqqBfpm_C8b8bw95EykonbcLWzFFQAC6ucgudZFQ@mail.gmail.com>
	<20200320065120.GW26184@telsasoft.com>
	<CAA4eK1+TQi4qanvLCOdcMbRKb=nCsJkWPhDi+KmOnkOyi79_Sw@mail.gmail.com>
	<20200320145359.GY26184@telsasoft.com>
	<CAA4eK1+iuT4gqiqYVdLkOggjA9q5v+dVxT_G3dOyHVokn+YjBg@mail.gmail.com>
	<CA+fd4k6jdiEW_+sPEMWS2TmSnE-ddAdFDSQu9WpXJsK6c2=+-Q@mail.gmail.com>
	<20200323081639.GI2563@telsasoft.com>
	<CAA4eK1KaWto3+4+EsLPRFL6HKs8=_42V2ivAFEPBU-o_o6AYXw@mail.gmail.com>

On Mon, Mar 23, 2020 at 02:25:14PM +0530, Amit Kapila wrote:
> > Yea, and it would be misleading if we reported "while scanning block..of
> > relation" if we actually failed while writing its FSM.
> >
> > My previous patches did this:
> >
> > +               case VACUUM_ERRCB_PHASE_VACUUM_FSM:
> > +                       errcontext("while vacuuming free space map of relation \"%s.%s\"",
> > +                                       cbarg->relnamespace, cbarg->relname);
> > +                       break;
> >
> 
> In what kind of errors will this help?

If there's an I/O error on an _fsm file, for one.

-- 
Justin

view thread (139+ messages)  latest in thread

Message-ID: <20200324041616.GA21443@telsasoft.com>
Permalink:  ../20200324041616.GA21443@telsasoft.com/
Also on:    postgresql.org/message-id/20200324041616.GA21443@telsasoft.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, amit.kapila16@gmail.com, masahiko.sawada@2ndquadrant.com, alvherre@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz
  Subject: Re: error context for vacuum to include block number
  In-Reply-To: <20200324041616.GA21443@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox