pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: James Coleman <jtc331@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Shaun Thomas <shaun.thomas@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Andreas Karlsson <andreas@proxel.se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: Mon, 6 Apr 2020 22:11:45 +0200
Message-ID: <20200406201145.ig56cdzrkt4u5mou@development> (raw)
In-Reply-To: <20200406195722.teiha6foiy3lix3s@development>
References: <CAAaqYe953TA0Pj+08jEBgK_=5zMCJO-vgYnh4n_Me71ZdzDJLg@mail.gmail.com>
	<20200401214215.ut6b72e3zlbm33w2@development>
	<CAAaqYe8fWa8pBUStzW-4JocF+d3pFBVLFmb9rtcD0m12NskBJw@mail.gmail.com>
	<20200402024746.5wlwk6q7eiv5faux@development>
	<CAAaqYe90h3F5NbgtNJAMrXAiGZwML8=_E_qs4MCyYtqea+5Hhg@mail.gmail.com>
	<20200403002028.kp3rxncmwvsui6xz@development>
	<CAAaqYe--jV9pHrX5NRw9R2QGG+nRuPPKguzHhKZwhp6XPOiyuQ@mail.gmail.com>
	<CAAaqYe9XO7ZKrpVkrz2e0ja=eeFCX0Wqpmc7r23R84JU9uCLxQ@mail.gmail.com>
	<20200405130110.2bdxaz4ed5jx2eae@development>
	<20200406195722.teiha6foiy3lix3s@development>

On Mon, Apr 06, 2020 at 09:57:22PM +0200, Tomas Vondra wrote:
>Hi,
>
>I've pushed the fist part of this patch series - I've reorganized it a
>bit by moving the add_partial_path changes to the end. That way I've
>been able to add regression test demonstrating impact of the change on
>plans involving incremental sort nodes (which wouldn't be possible when
>committing the add_partial_path first). I'll wait a bit before pushing
>the two additional parts, so that if something fails we know which bit
>caused it.
>

Hmmm, I see the buildfarm is not happy about it - a couple of animals
failed, but some succeeded. The failure seems like a simple difference
in explain output, but it's not clear why would it happen (and I've
ran the tests many times but never seen this failure).

Investigating.

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services 





view thread (262+ messages)  latest in thread

Message-ID: <20200406201145.ig56cdzrkt4u5mou@development>
Permalink:  ../20200406201145.ig56cdzrkt4u5mou@development/
Also on:    postgresql.org/message-id/20200406201145.ig56cdzrkt4u5mou@development

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, jtc331@gmail.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, michael@paquier.xyz, rafia.pghackers@gmail.com, pg@bowt.ie, simon@2ndquadrant.com, shaun.thomas@2ndquadrant.com, 9erthalion6@gmail.com, a.korotkov@postgrespro.ru, pgsql-hackers@lists.postgresql.org, andreas@proxel.se
  Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
  In-Reply-To: <20200406201145.ig56cdzrkt4u5mou@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox