pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add -Wold-style-definition to CFLAGS?
Date: Sun, 10 May 2020 10:37:59 +0900
Message-ID: <20200510013759.GA2004@paquier.xyz> (raw)
In-Reply-To: <19295.1589065916@sss.pgh.pa.us>
References: <20200509174820.g4bwftmz7blz35ph@alap3.anarazel.de>
	<4838.1589048101@sss.pgh.pa.us>
	<20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de>
	<19295.1589065916@sss.pgh.pa.us>

On Sat, May 09, 2020 at 07:11:56PM -0400, Tom Lane wrote:
> I'd be OK with pushing it now, but I dunno about other people.

Sounds like a good idea to me to apply this part now.

> If we do want to push this sort of thing now, the nearby changes
> to enable fallthrough warnings should go in too.

If we do that, merging this second part before beta1 is out looks like
a good compromise to me.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (9+ messages)  latest in thread

Message-ID: <20200510013759.GA2004@paquier.xyz>
Permalink:  ../20200510013759.GA2004@paquier.xyz/
Also on:    postgresql.org/message-id/20200510013759.GA2004@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: Add -Wold-style-definition to CFLAGS?
  In-Reply-To: <20200510013759.GA2004@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox