From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Isaac Morland <isaac.morland@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: Our naming of wait events is a disaster.
Date: Thu, 14 May 2020 16:56:54 -0400
Message-ID: <20200514205654.GA24219@alvherre.pgsql> (raw)
In-Reply-To: <1261.1589488034@sss.pgh.pa.us>
On 2020-May-14, Tom Lane wrote:
> A case could be made for doing s/async/notify/ more widely in async.c;
> for instance it's odd that the struct protected by NotifyQueueLock
> didn't get renamed to NotifyQueueControl. But that seems a bit out
> of scope for the immediate problem, and anyway I'm not sure how far to
> take it. I don't really want to rename async.c's externally-visible
> functions, for instance. For the moment I just renamed symbols used
> in the SimpleLruInit() call.
That approach seems fine -- we'd only rename those things if and when we
modified them for other reasons; and the file itself, probably not at all.
Much like our renaming of XLOG to WAL, we changed the user-visible term
all at once, but the code kept the original names until changed.
Maybe in N years, when the SCM tooling is much better (so that it
doesn't get confused by us having renamed the file in the newer branches
and back-patching to an older branch), we can rename xlog.c to wal.c and
async.c to notify.c. Or maybe not.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, isaac.morland@gmail.com, robertmhaas@gmail.com
Subject: Re: Our naming of wait events is a disaster.
In-Reply-To: <20200514205654.GA24219@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox