From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: some more pg_dump refactoring
Date: Thu, 9 Jul 2020 12:56:27 -0400
Message-ID: <20200709165627.GA24091@alvherre.pgsql> (raw)
In-Reply-To: <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com>
On 2020-Jul-09, Peter Eisentraut wrote:
> On 2020-07-08 06:42, Fabien COELHO wrote:
> > > What do you think about this patch to reorganize the existing code from that
> > > old commit?
> >
> > I think it is a definite further improvement.
> >
> > Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to
> > me.
>
> Thanks. I have committed that, and attached is my original patch adjusted
> to this newer style.
Thanks, I too prefer the style where queries are split in lines instead
of a single very long one, at least when looking at log_statement=all
lines generated by pg_dump runs. It's not a *huge* usability
improvement, but I see no reason to make things worse.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, coelho@cri.ensmp.fr
Subject: Re: some more pg_dump refactoring
In-Reply-To: <20200709165627.GA24091@alvherre.pgsql>
References: <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com> <20200709165627.GA24091@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox