pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: please update ps display for recovery checkpoint
Date: Thu, 3 Dec 2020 15:58:09 -0600
Message-ID: <20201203215809.GS24052@telsasoft.com> (raw)
In-Reply-To: <9A1B9D98-4576-438A-943F-0AFB05946C7C@amazon.com>
References: <20200818225238.GP17022@telsasoft.com>
	<OSBPR01MB2341D2D3141FB3E4C97A0B4DEF5D0@OSBPR01MB2341.jpnprd01.prod.outlook.com>
	<20200820080905.GA10353@paquier.xyz>
	<20200831065244.GB6555@paquier.xyz>
	<20200910020050.GB18552@telsasoft.com>
	<20200910043710.GD2743@paquier.xyz>
	<20200919160031.GC30557@telsasoft.com>
	<20201002072814.GE1464@paquier.xyz>
	<20201002091354.GH8476@telsasoft.com>
	<9A1B9D98-4576-438A-943F-0AFB05946C7C@amazon.com>

On Thu, Dec 03, 2020 at 09:18:07PM +0000, Bossart, Nathan wrote:
> I considered also checking that update_process_title was enabled, but
> I figured that these ps display updates should happen sparsely enough
> that it wouldn't make much of an impact.

Since bf68b79e5, update_ps_display is responsible for checking
update_process_title.  Its other, remaining uses are apparently just acting as
minor optimizations to guard against useless snprintf's.

See also https://www.postgresql.org/message-id/flat/1288021.1600178478%40sss.pgh.pa.us
in which (I just saw) Tom wrote:

> Seems like a good argument, but you'd have to be careful about the
> final state when you stop overriding update_process_title --- it can't
> be left looking like it's still-in-progress on some random WAL file.

I think that's a live problem, not just a concern for that patch.
It was exactly my complaint leading to this thread:

> But runs a checkpoint, which can take a long time, while the "ps" display still
> says "recovering NNNNNNNN".

-- 
Justin





view thread (30+ messages)  latest in thread

Message-ID: <20201203215809.GS24052@telsasoft.com>
Permalink:  ../20201203215809.GS24052@telsasoft.com/
Also on:    postgresql.org/message-id/20201203215809.GS24052@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, bossartn@amazon.com, michael@paquier.xyz, k.jamison@fujitsu.com, thomas.munro@gmail.com
  Subject: Re: please update ps display for recovery checkpoint
  In-Reply-To: <20201203215809.GS24052@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox