pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Cc: schneider@ardentperf.com
Subject: Re: monitoring usage count distribution
Date: Wed, 05 Apr 2023 15:07:10 -0400
Message-ID: <2020452.1680721630@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYRHDDJTgPcFkomz4KzzsQHXRJtqKeJyOk4AZNTjf=TnQ@mail.gmail.com>
References: <20230130233040.GA2800702@nathanxps13>
	<CA+Tgmoa-c3avHFBdko9d7bGQuYXrJhHHjhG1yAs8h-k_sLbyPQ@mail.gmail.com>
	<20230404232919.uibzbhjdylk3mlvp@awork3.anarazel.de>
	<CA+TgmobrQ90KGN4dwxL8q-LV529gCMmzXiy8CG5eQwjYTPzZLA@mail.gmail.com>
	<20230405175124.GA31516@nathanxps13>
	<CA+TgmoYRHDDJTgPcFkomz4KzzsQHXRJtqKeJyOk4AZNTjf=TnQ@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Apr 5, 2023 at 1:51 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> The six-element array approach won't show the number of dirty and pinned
>> buffers for each usage count, but I'm not sure that's a deal-breaker.
>> Barring objections, I'll post an updated patch shortly with that approach.

> Right, well, I would personally be OK with 6 rows too, but I don't
> know what other people want.  I think either this or that is better
> than average.

Seems to me that six rows would be easier to aggregate manually.
An array column seems less SQL-ish and harder to manipulate.

			regards, tom lane





view thread (20+ messages)  latest in thread

Message-ID: <2020452.1680721630@sss.pgh.pa.us>
Permalink:  ../2020452.1680721630@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2020452.1680721630@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, nathandbossart@gmail.com, andres@anarazel.de, schneider@ardentperf.com
  Subject: Re: monitoring usage count distribution
  In-Reply-To: <2020452.1680721630@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox