From: Stephen Frost <sfrost@snowman.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Mon, 26 Apr 2021 13:23:54 -0400
Message-ID: <20210426172354.GV20766@tamriel.snowman.net> (raw)
In-Reply-To: <CABUevExH+nLxfYqbUYV3zB7QqaCrzxRAbnTrs0Dbt4f0W1Xn=A@mail.gmail.com>
References: <20210424152220.GL7629@momjian.us>
<CABUevEx4YQi42MwaMq3Bo09=mBqfjUqtkp5NUZpnQ0HdX+5+Hw@mail.gmail.com>
<20210424170908.GM7629@momjian.us>
<1709439.1619286231@sss.pgh.pa.us>
<e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com>
<YIbdhrfemBnwAvl5@msg.df7cb.de>
<20210426162104.GQ7629@momjian.us>
<20210426163135.GU20766@tamriel.snowman.net>
<2267128.1619456173@sss.pgh.pa.us>
<CABUevExH+nLxfYqbUYV3zB7QqaCrzxRAbnTrs0Dbt4f0W1Xn=A@mail.gmail.com>
Greetings,
* Magnus Hagander (magnus@hagander.net) wrote:
> On Mon, Apr 26, 2021 at 6:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> > > * Bruce Momjian (bruce@momjian.us) wrote:
> > >> Techically, pg_stat_statements can turn on compute_query_id when it is
> > >> loaded, even if it is 'off' in postgresql.conf, right? And
> > >> pg_stat_statements would know if an alternate hash method is being used,
> > >> right?
> >
> > > +1 on this approach.
> >
> > That'd make it impossible to turn off or adjust afterwards, wouldn't it?
> > I'm afraid the confusion stemming from that would outweigh any simplicity.
I don't know that it actually would, but ...
> Thatäs why I suggested the three value one. Default to a mode where
> it's automatic, which is what the majority is going to want, but have
> a way to explicitly turn it on.
This is certainly fine with me too, though it seems a bit surprising to
me that we couldn't just figure out what the user actually wants based
on what's installed/running for any given combination.
> > In the end, it's not like this is the first time we've ever made an
> > incompatible change in configuration needs; and it won't be the last
> > either. I don't buy the argument that pg_stat_statements users can't
> > cope with adding the additional setting. (Of course, we should be
> > careful to call it out as an incompatible change in the release notes.)
>
> The fact that we've made changes before that complicated our users
> experience isn't in itself an argument for doing it again though...
I'm generally a proponent of sensible changes across major versions even
if it means that the user has to adjust things, but this seems like a
case where we're punting on something that we really should just be able
to figure out the right answer to and that seems like a step backwards.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, magnus@hagander.net, tgl@sss.pgh.pa.us, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, masao.fujii@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <20210426172354.GV20766@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox