pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Tue, 25 Jan 2022 10:45:29 -0600
Message-ID: <20220125164529.GG23027@telsasoft.com> (raw)
In-Reply-To: <Ye4IDNnbMQ5IRxv9@paquier.xyz>
References: <20211222163611.GC17618@telsasoft.com>
	<20220108184857.GI14051@telsasoft.com>
	<Yd00xmV+rdffAQxf@paquier.xyz>
	<20220111200307.GA14051@telsasoft.com>
	<Yd5SOupY+FHbiXLD@paquier.xyz>
	<20220112040813.GD14051@telsasoft.com>
	<YefIHrNYTNH/PML4@paquier.xyz>
	<45e7680a-b617-1397-afa0-35a793aacefe@enterprisedb.com>
	<Yek+uQp/kMn2O3aK@paquier.xyz>
	<Ye4IDNnbMQ5IRxv9@paquier.xyz>

On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote:
> On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote:
> > Neat idea.  That would work fine for my case.  So I am fine to stick
> > with this suggestion. 
> 
> I have been looking at this idea, and the result is quite nice, being
> simpler than anything that has been proposed on this thread yet.  We
> get a simpler removal logic, and there is no need to perform any kind
> of sanity checks with the output path provided as long as we generate
> the paths and the dirs after adjust_data_dir().
> 
> Thoughts?

Andrew: you wanted to accommodate any change on the build client, right ?

-- 
Justin





view thread (53+ messages)  latest in thread

Message-ID: <20220125164529.GG23027@telsasoft.com>
Permalink:  ../20220125164529.GG23027@telsasoft.com/
Also on:    postgresql.org/message-id/20220125164529.GG23027@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, daniel@yesql.se, andrew@dunslane.net, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_upgrade should truncate/remove its logs before running
  In-Reply-To: <20220125164529.GG23027@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox