pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: out of date comment in commit_ts.c
Date: Wed, 27 Jul 2022 13:29:52 -0700
Message-ID: <20220727202952.GA226176@nathanxps13> (raw)
In-Reply-To: <20220726173343.GA154110@nathanxps13>
References: <20220726173343.GA154110@nathanxps13>

On Tue, Jul 26, 2022 at 10:33:43AM -0700, Nathan Bossart wrote:
> IIUC the ability for callers to request WAL record generation is no longer
> possible as of 08aa89b [0].  Should the second sentence be removed?

Here's a patch.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachments:

fix_commit_ts_comment.patch (text/x-diff, 1.2K) download diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 4dc8d402bd..9aa4675cb7 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -7,13 +7,10 @@ * for each transaction. * * XLOG interactions: this module generates an XLOG record whenever a new - * CommitTs page is initialized to zeroes. Also, one XLOG record is - * generated for setting of values when the caller requests it; this allows - * us to support values coming from places other than transaction commit. - * Other writes of CommitTS come from recording of transaction commit in - * xact.c, which generates its own XLOG records for these events and will - * re-perform the status update on redo; so we need make no additional XLOG - * entry here. + * CommitTs page is initialized to zeroes. Other writes of CommitTS come + * from recording of transaction commit in xact.c, which generates its own + * XLOG records for these events and will re-perform the status update on + * redo; so we need make no additional XLOG entry here. * * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California

view thread (4+ messages)  latest in thread

Message-ID: <20220727202952.GA226176@nathanxps13>
Permalink:  ../20220727202952.GA226176@nathanxps13/
Also on:    postgresql.org/message-id/20220727202952.GA226176@nathanxps13

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com
  Subject: Re: out of date comment in commit_ts.c
  In-Reply-To: <20220727202952.GA226176@nathanxps13>
  References: <20220726173343.GA154110@nathanxps13> <20220727202952.GA226176@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox