pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Imseih (AWS), Sami <simseih@amazon.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: robertmhaas@gmail.com <robertmhaas@gmail.com>
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
Date: Tue, 29 Aug 2023 09:46:55 -0700
Message-ID: <20230829164655.GA2138073@nathanxps13> (raw)
In-Reply-To: <ZOv+MHonWVgW/bpf@paquier.xyz>
References: <CAB8KJ=j-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few@mail.gmail.com>
	<20230824023206.GA1128857@nathanxps13.lan>
	<20230824025140.GB1128857@nathanxps13.lan>
	<20230824161913.GA1394441@nathanxps13.lan>
	<CAB8KJ=iWYvB1odjFRZybsPeUV8HUAiVVjY9RMHSdvWy1t77cLg@mail.gmail.com>
	<20230825153251.GA1593219@nathanxps13>
	<20230825192949.GA1917227@nathanxps13>
	<CF0C64D6-BB5C-4F84-98BB-8852A1C01A40@amazon.com>
	<ZOv+MHonWVgW/bpf@paquier.xyz>

On Mon, Aug 28, 2023 at 10:53:52AM +0900, Michael Paquier wrote:
> I understand that this is not a fantastic naming, but renaming
> pgstat_fetch_stat_local_beentry() to something like
> pgstat_fetch_stat_local_beentry_by_{index|position}_id() would make
> the difference much easier to grasp, and we should avoid the use of
> "beid" when we refer to the *position/index ID* in
> localBackendStatusTable, because it is not a BackendId at all, just a
> position in the local array.

This was my first reaction [0].  I was concerned about renaming the
exported functions so close to release, so I was suggesting that we hold
off on that part until v17.  If there isn't a concern with renaming these
functions in v16, I can proceed with something more like v2.

[0] https://postgr.es/m/20230824161913.GA1394441%40nathanxps13.lan

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (22+ messages)  latest in thread

Message-ID: <20230829164655.GA2138073@nathanxps13>
Permalink:  ../20230829164655.GA2138073@nathanxps13/
Also on:    postgresql.org/message-id/20230829164655.GA2138073@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, michael@paquier.xyz, simseih@amazon.com, barwick@gmail.com, robertmhaas@gmail.com
  Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
  In-Reply-To: <20230829164655.GA2138073@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox