pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: bt23nguyent <bt23nguyent@oss.nttdata.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: Mon, 25 Sep 2023 15:20:47 -0700
Message-ID: <20230925222047.GA3173226@nathanxps13> (raw)
In-Reply-To: <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
References: <202309151049.dmfsxc5b3wyf@alvherre.pgsql>
	<7035FAFE-7E91-4B31-AA72-75EE82DB3F7B@yesql.se>
	<20230915143827.GA1912920@nathanxps13>
	<85b9e69997bbd5d8302a3a99a2de246d@oss.nttdata.com>
	<D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
	<18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>

On Thu, Sep 21, 2023 at 11:18:00AM +0900, bt23nguyent wrote:
> -basic_archive_configured(ArchiveModuleState *state)
> +basic_archive_configured(ArchiveModuleState *state, char **logdetail)

Could we do something more like GUC_check_errdetail() instead to maintain
backward compatibility with v16?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (22+ messages)  latest in thread

Message-ID: <20230925222047.GA3173226@nathanxps13>
Permalink:  ../20230925222047.GA3173226@nathanxps13/
Also on:    postgresql.org/message-id/20230925222047.GA3173226@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, bt23nguyent@oss.nttdata.com, daniel@yesql.se, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
  In-Reply-To: <20230925222047.GA3173226@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox