pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: bt23nguyent <bt23nguyent@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: Mon, 04 Mar 2024 17:05:24 -0500
Message-ID: <3884544.1709589924@sss.pgh.pa.us> (raw)
In-Reply-To: <20240304215048.GA3367383@nathanxps13>
References: <D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
	<18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
	<20230925222047.GA3173226@nathanxps13>
	<482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
	<20231013022559.GA1266364@nathanxps13>
	<E863EDCA-EFEA-4DFA-9E93-024D464DE260@yesql.se>
	<20240105230357.GA2425960@nathanxps13>
	<AB31C950-5BA6-49F2-ADF9-F8E8334EB4A2@yesql.se>
	<20240304172252.GA3161951@nathanxps13>
	<1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>
	<20240304215048.GA3367383@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
>> Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
>> Alvaro's name seems wrong.

> Hm.  It looks alright to me.  I copied the name from his e-mail signature,
> which has an accent over the first 'A'.  I assume that's why it's not
> showing up correctly in some places.

I think that git has an expectation of commit log entries being in
UTF8.  The committed message looks okay from my end, but maybe some
encoding mangling happened to the version Daniel was looking at?

			regards, tom lane





view thread (22+ messages)

Message-ID: <3884544.1709589924@sss.pgh.pa.us>
Permalink:  ../3884544.1709589924@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3884544.1709589924@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, daniel@yesql.se, bt23nguyent@oss.nttdata.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
  In-Reply-To: <3884544.1709589924@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox