From: Nathan Bossart <nathandbossart@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: bt23nguyent <bt23nguyent@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: Thu, 12 Oct 2023 21:25:59 -0500
Message-ID: <20231013022559.GA1266364@nathanxps13> (raw)
In-Reply-To: <482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
References: <202309151049.dmfsxc5b3wyf@alvherre.pgsql>
<7035FAFE-7E91-4B31-AA72-75EE82DB3F7B@yesql.se>
<20230915143827.GA1912920@nathanxps13>
<85b9e69997bbd5d8302a3a99a2de246d@oss.nttdata.com>
<D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
<18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
<20230925222047.GA3173226@nathanxps13>
<482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
On Tue, Sep 26, 2023 at 08:13:45AM +0200, Daniel Gustafsson wrote:
>> On 26 Sep 2023, at 00:20, Nathan Bossart <nathandbossart@gmail.com> wrote:
>>
>> On Thu, Sep 21, 2023 at 11:18:00AM +0900, bt23nguyent wrote:
>>> -basic_archive_configured(ArchiveModuleState *state)
>>> +basic_archive_configured(ArchiveModuleState *state, char **logdetail)
>>
>> Could we do something more like GUC_check_errdetail() instead to maintain
>> backward compatibility with v16?
>
> We'd still need something exported to call into which isn't in 16, so it
> wouldn't be more than optically backwards compatible since a module written for
> 17 won't compile for 16, or am I missing something?
I only mean that a module written for v16 could continue to be used in v17
without any changes. You are right that a module that uses this new
functionality wouldn't compile for v16. But IMHO the interface is nicer,
too, since module authors wouldn't need to worry about allocating the space
for the string or formatting the message.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, daniel@yesql.se, bt23nguyent@oss.nttdata.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
In-Reply-To: <20231013022559.GA1266364@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox