pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: noah@leadboat.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: add non-option reordering to in-tree getopt_long
Date: Mon, 18 Dec 2023 15:52:01 -0600
Message-ID: <20231218215201.GA586573@nathanxps13> (raw)
In-Reply-To: <4007895.1702928482@sss.pgh.pa.us>
References: <20230710200658.GA362078@nathanxps13>
	<20230711.161609.1881651378858129172.horikyota.ntt@gmail.com>
	<20230711163232.GA616878@nathanxps13>
	<20230713034903.GA991765@nathanxps13>
	<ZK+OFMbpICfO1aTR@paquier.xyz>
	<20230713145712.GA1049722@nathanxps13>
	<ZLDOrsxEqbV5vVzx@paquier.xyz>
	<20230714043842.GB327716@nathanxps13>
	<ZLDW5HjNS1Ys43xP@paquier.xyz>
	<4007895.1702928482@sss.pgh.pa.us>

On Mon, Dec 18, 2023 at 02:41:22PM -0500, Tom Lane wrote:
> We just had a user complaint that seems to trace to exactly this
> bogus reporting in pg_ctl [1].  Although I was originally not
> very pleased with changing our getopt_long to do switch reordering,
> I'm now wondering if we should back-patch these changes as bug
> fixes.  It's probably not worth the risk, but ...

I'm not too concerned about the risks of back-patching these commits, but
if this 19-year-old bug was really first reported today, I'd agree that
fixing it in the stable branches is probably not worth it.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (37+ messages)  latest in thread

Message-ID: <20231218215201.GA586573@nathanxps13>
Permalink:  ../20231218215201.GA586573@nathanxps13/
Also on:    postgresql.org/message-id/20231218215201.GA586573@nathanxps13

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, horikyota.ntt@gmail.com, noah@leadboat.com
  Subject: Re: add non-option reordering to in-tree getopt_long
  In-Reply-To: <20231218215201.GA586573@nathanxps13>
  References: <20230710200658.GA362078@nathanxps13> <20230711.161609.1881651378858129172.horikyota.ntt@gmail.com> <20230711163232.GA616878@nathanxps13> <20230713034903.GA991765@nathanxps13> <ZK+OFMbpICfO1aTR@paquier.xyz> <20230713145712.GA1049722@nathanxps13> <ZLDOrsxEqbV5vVzx@paquier.xyz> <20230714043842.GB327716@nathanxps13> <ZLDW5HjNS1Ys43xP@paquier.xyz> <4007895.1702928482@sss.pgh.pa.us> <20231218215201.GA586573@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox