From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: noah@leadboat.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: add non-option reordering to in-tree getopt_long
Date: Mon, 18 Dec 2023 21:31:54 -0500
Message-ID: <4139302.1702953114@sss.pgh.pa.us> (raw)
In-Reply-To: <20231218215201.GA586573@nathanxps13>
References: <20230710200658.GA362078@nathanxps13>
<20230711.161609.1881651378858129172.horikyota.ntt@gmail.com>
<20230711163232.GA616878@nathanxps13>
<20230713034903.GA991765@nathanxps13>
<ZK+OFMbpICfO1aTR@paquier.xyz>
<20230713145712.GA1049722@nathanxps13>
<ZLDOrsxEqbV5vVzx@paquier.xyz>
<20230714043842.GB327716@nathanxps13>
<ZLDW5HjNS1Ys43xP@paquier.xyz>
<4007895.1702928482@sss.pgh.pa.us>
<20231218215201.GA586573@nathanxps13>
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Dec 18, 2023 at 02:41:22PM -0500, Tom Lane wrote:
>> We just had a user complaint that seems to trace to exactly this
>> bogus reporting in pg_ctl [1]. Although I was originally not
>> very pleased with changing our getopt_long to do switch reordering,
>> I'm now wondering if we should back-patch these changes as bug
>> fixes. It's probably not worth the risk, but ...
> I'm not too concerned about the risks of back-patching these commits, but
> if this 19-year-old bug was really first reported today, I'd agree that
> fixing it in the stable branches is probably not worth it.
Agreed, if it actually is 19 years old. I'm wondering a little bit
if there could be some moderately-recent glibc behavior change
involved. I'm not excited enough about it to go trawl their change
log, but we should keep our ears cocked for similar reports.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, michael@paquier.xyz, horikyota.ntt@gmail.com, noah@leadboat.com
Subject: Re: add non-option reordering to in-tree getopt_long
In-Reply-To: <4139302.1702953114@sss.pgh.pa.us>
References: <20230710200658.GA362078@nathanxps13> <20230711.161609.1881651378858129172.horikyota.ntt@gmail.com> <20230711163232.GA616878@nathanxps13> <20230713034903.GA991765@nathanxps13> <ZK+OFMbpICfO1aTR@paquier.xyz> <20230713145712.GA1049722@nathanxps13> <ZLDOrsxEqbV5vVzx@paquier.xyz> <20230714043842.GB327716@nathanxps13> <ZLDW5HjNS1Ys43xP@paquier.xyz> <4007895.1702928482@sss.pgh.pa.us> <20231218215201.GA586573@nathanxps13> <4139302.1702953114@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox