pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kumar, Sachin <ssetiya@amazon.com>
Cc: Jan Wieck <jan@wi3ck.info>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Robins Tharakan <tharakan@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
Date: Fri, 12 Jan 2024 16:56:35 -0600
Message-ID: <20240112225635.GA4033820@nathanxps13> (raw)
In-Reply-To: <20240112224227.GA3857154@nathanxps13>
References: <20220908231807.GA2242918@nathanxps13>
	<CAAWbhmgUb8p7ff_ZX5jCvqM=ipPxbbDJTXMNVzH-Ho_CXVkRHA@mail.gmail.com>
	<0643CC11-223A-4039-AC34-94E127462796@amazon.com>
	<1152134.1699555261@sss.pgh.pa.us>
	<83D44BE5-0088-4D41-8AE6-20A05D026F46@amazon.com>
	<81D13E16-BA04-43CF-9B89-B8924300B211@amazon.com>
	<240D05EC-8B28-4112-BEAB-85ECBAF3F871@amazon.com>
	<2055911.1702258962@sss.pgh.pa.us>
	<534746.1703116064@sss.pgh.pa.us>
	<20240112224227.GA3857154@nathanxps13>

On Fri, Jan 12, 2024 at 04:42:27PM -0600, Nathan Bossart wrote:
> On Wed, Dec 20, 2023 at 06:47:44PM -0500, Tom Lane wrote:
>> +			char	   *cmdEnd = psprintf(" OWNER TO %s", fmtId(te->owner));
>> +
>> +			IssueCommandPerBlob(AH, te, "ALTER LARGE OBJECT ", cmdEnd);
> 
> This is just a nitpick, but is there any reason not to have
> IssueCommandPerBlob() accept a format string and the corresponding
> arguments?

Eh, I guess you'd have to find some other way of specifying where the OID
is supposed to go, which would probably be weird.  Please disregard this
one.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (93+ messages)  latest in thread

Message-ID: <20240112225635.GA4033820@nathanxps13>
Permalink:  ../20240112225635.GA4033820@nathanxps13/
Also on:    postgresql.org/message-id/20240112225635.GA4033820@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, ssetiya@amazon.com, jan@wi3ck.info, bruce@momjian.us, zyu@yugabyte.com, andrew@dunslane.net, magnus@hagander.net, tharakan@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: pg_upgrade failing for 200+ million Large Objects
  In-Reply-To: <20240112225635.GA4033820@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox