From: Álvaro Herrera <alvherre@kurilemu.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Wed, 19 Nov 2025 23:03:59 +0100
Message-ID: <202511192201.3wvvrchnvyfb@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoaYY8nEmEgabLjQdUfqThQH4BYcBScv_SRkx-OsFukV=g@mail.gmail.com>
On 2025-Nov-19, Robert Haas wrote:
> I do not know how to make the phrase "older minor releases" any more
> clear.
It's perfectly clear. I just don't believe this claim.
> You and Álvaro seem to be under the impression that nobody will
> ever try to compile code written after this change from a point
> release that we shipped before this change. While I don't think that
> will be a common thing to do, I'm not sure where you get the idea that
> older minor releases completely cease to be relevant when we release a
> new one. That's just not how it works.
I'm sure compiled versions continue to be relevant, but I highly doubt
anybody compiles afresh with old minors.
> I bet if we look in a few years we'll find modules on PGXN that have
> #ifdef logic in them to make sure they can work with both
> XLogRecPtrIsInvalid and XLogRecPtrIsValid.
Ok, let's wait a few years and see. My bet is you won't find any.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, robertmhaas@gmail.com, bertranddrouvot.pg@gmail.com, peter@eisentraut.org, michael@paquier.xyz, hlinnaka@iki.fi, quanzongliang@yeah.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
In-Reply-To: <202511192201.3wvvrchnvyfb@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox