From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: libpq error message refactoring
Date: Thu, 22 Sep 2022 22:40:47 -0400
Message-ID: <2032898.1663900847@sss.pgh.pa.us> (raw)
In-Reply-To: <20220923022727.mclhsv3cjbmdrrkd@awork3.anarazel.de>
References: <7c0232ef-7b44-68db-599d-b327d0640a77@enterprisedb.com>
<20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>
<d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com>
<20220923022727.mclhsv3cjbmdrrkd@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> I suspect the appendPQExpBufferVA is orthogonal - most (all?) of the other
> functions in pqexpbuffer.h are visible, so it feels weird/confusing to not
> make appendPQExpBufferVA() available.
I thought the same to start with, but if I'm right in my nearby reply
that we'll have to make callers loop around appendPQExpBufferVA,
then it seems like a good idea to keep it closely held.
More than zero commentary about that would be a good thing, too.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@enterprisedb.com
Subject: Re: libpq error message refactoring
In-Reply-To: <2032898.1663900847@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox