pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: gurjeet@singh.im
Cc: pgsql-hackers@postgresql.org
Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
Date: Mon, 25 Jul 2022 15:46:18 -0400
Message-ID: <2062116.1658778378@sss.pgh.pa.us> (raw)
In-Reply-To: <87ilnli57b.fsf@wibble.ilmari.org>
References: <CABwTF4WXCbjEpVRq+G+MZeJEXU=2evYMb_DVdzXpWap5cczkcQ@mail.gmail.com>
	<Ytn2ssEKdzPFM3Vf@paquier.xyz>
	<20220722.151600.1094104349120879204.horikyota.ntt@gmail.com>
	<729330.1658516182@sss.pgh.pa.us>
	<20220722223359.GB3998906@nathanxps13>
	<763512.1658529844@sss.pgh.pa.us>
	<20220722225615.GC3998906@nathanxps13>
	<954936.1658597004@sss.pgh.pa.us>
	<20220725034040.GA4085281@nathanxps13>
	<1834276.1658720963@sss.pgh.pa.us>
	<20220725043044.GC4085281@nathanxps13>
	<2015981.1658759562@sss.pgh.pa.us>
	<87ilnli57b.fsf@wibble.ilmari.org>

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I wonder if it'd be a good idea to convert
>> auto_explain's TAP test to load auto_explain via session_preload_libraries
>> instead of shared_preload_libraries, and then pass in the settings for
>> each test via PGOPTIONS instead of constantly rewriting postgresql.conf.

> That whole config-file rewriting did feel a bit icky when I added more
> tests recently, but I completely forgot about PGOPTIONS and -c.
> Something like the attached is indeed much nicer.

Thanks!  I added a test to verify the permissions-checking issue
and pushed it.

			regards, tom lane





view thread (25+ messages)  latest in thread

Message-ID: <2062116.1658778378@sss.pgh.pa.us>
Permalink:  ../2062116.1658778378@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2062116.1658778378@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ilmari@ilmari.org, nathandbossart@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, gurjeet@singh.im
  Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
  In-Reply-To: <2062116.1658778378@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox