From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: Wed, 15 Feb 2023 10:07:43 -0500
Message-ID: <2083679.1676473663@sss.pgh.pa.us> (raw)
In-Reply-To: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>
References: <20230215101159.ef5usgukz2qfgp5n@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Note that there's another file, xml_2.out, which does not contain the
> additional part of the DETAIL message. I suspect in Peter's case it's
> xml_2.out that was originally being used as a comparison basis (not
> xml.out), but that one is not getting patched, and ultimately the diff
> is reported for him against xml.out because none of them matches.
> See commit 085423e3e326 for a bit of background.
Yeah. That's kind of sad, because it means there are still broken
libxml2s out there in 2023. Nonetheless, since there are, it is not
optional to fix all three expected-files.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, smithpb2250@gmail.com, jim.jones@uni-muenster.de, peter.eisentraut@enterprisedb.com
Subject: Re: [PATCH] Add pretty-printed XML output option
In-Reply-To: <2083679.1676473663@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox