From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
Date: Fri, 18 Nov 2022 20:04:40 -0500
Message-ID: <2304165.1668819880@sss.pgh.pa.us> (raw)
In-Reply-To: <20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de>
References: <2267406.1668804934@sss.pgh.pa.us>
<20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
>> The test_oat_hooks test is failing --- it's not crashing, but
>> it's emitting more NOTICE lines than the expected output includes,
>> evidently as a result of the hooks getting invoked extra times
>> during cache reloads. I can reproduce that here.
> Did you already look into where those additional namespace searches are coming
> from? There are case in which it is not unproblematic to have repeated
> namespace searches due to the potential for races it opens up...
I'm not sufficiently interested in that API to dig hard for details,
but in a first look it seemed like the extra reports were coming
from repeated executions of recomputeNamespacePath, which are
forced after a cache invalidation by NamespaceCallback.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, tomas.vondra@enterprisedb.com
Subject: Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
In-Reply-To: <2304165.1668819880@sss.pgh.pa.us>
References: <2267406.1668804934@sss.pgh.pa.us> <20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de> <2304165.1668819880@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox