pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: WIN32 pg_import_system_collations
Date: Sun, 26 Feb 2023 16:02:38 -0500
Message-ID: <237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net> (raw)
In-Reply-To: <784b2fa1-2e65-fce1-929c-e9de535b9230@enterprisedb.com>
References: <0050ec23-34d9-2765-9015-98c04f0e18ac@postgrespro.ru>
	<639e0abd-ea82-b751-bfba-5166a7a1b304@enterprisedb.com>
	<CAC+AXB0kd+YgF408sy5c2Bsa3PQdiSS6YJZLq6TMx33_WTJ-rA@mail.gmail.com>
	<20220322010057.w7mzoahyi3jy5dyf@alap3.anarazel.de>
	<CAC+AXB1v_H68VQoXK=Pdnc7VwUC-9ifdQEtvyx_qEkMiBGJKbw@mail.gmail.com>
	<CAC+AXB1ha0tnWcqMdjaBq_Lkw346E+h_5UqeYK5NZ29WR8a-bQ@mail.gmail.com>
	<f0ca9ad8-67f9-6d18-ec15-9525f864fa12@enterprisedb.com>
	<CAC+AXB078_wJumwG9nOP--m3cTWKhAUeC22S73rUMVhXknstUg@mail.gmail.com>
	<9f1c24f0-9340-8044-94e7-5f5389a53d08@enterprisedb.com>
	<CAC+AXB2VTU3Udv0nPMB3xO30rnpxcEsFuog7q30S_VmErS4b8g@mail.gmail.com>
	<CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com>
	<a6c3880a-e887-5ac5-c0bd-f72604ceb53d@enterprisedb.com>
	<CAC+AXB2Y4zi-U5L3agNgbFmejV0A3x+YB+bb4KmBGigSZBVvbA@mail.gmail.com>
	<784b2fa1-2e65-fce1-929c-e9de535b9230@enterprisedb.com>


On 2023-01-03 Tu 08:48, Peter Eisentraut wrote:
> On 09.12.22 13:48, Juan José Santamaría Flecha wrote:
>> On Thu, Dec 1, 2022 at 8:46 AM Peter Eisentraut 
>> <peter.eisentraut@enterprisedb.com 
>> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
>>
>>
>>     What is the status of this now?  I think the other issue has been
>>     addressed?
>>
>>
>> Yes, that's addressed for MSVC builds. I think there are a couple of 
>> pending issues for MinGW, but those should have their own threads.
>>
>> The patch had rotten, so PFA a rebased version.
>
> committed
>
>

Now that I have removed the barrier to testing this in the buildfarm, 
and added an appropriate locale setting to drongo, we can see that this 
test fails like this:



inline patch 1: c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out (+3/-2 lines) download inline-1.patchdiff -w -U3 c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out
--- c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out	2023-01-23 04:39:06.755149600 +0000
+++ c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out	2023-02-26 17:32:54.115515200 +0000
@@ -363,16 +363,17 @@
  
  -- to_char
  SET lc_time TO 'de_DE';
+ERROR:  invalid value for parameter "lc_time": "de_DE"
  SELECT to_char(date '2010-03-01', 'DD TMMON YYYY');
     to_char
  -------------
- 01 MRZ 2010
+ 01 MAR 2010
  (1 row)
  
  SELECT to_char(date '2010-03-01', 'DD TMMON YYYY' COLLATE "de_DE");
     to_char
  -------------
- 01 MRZ 2010
+ 01 MAR 2010
  (1 row)
  
  -- to_date



The last of these is especially an issue, as it doesn't even throw an error.

See 
<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2023-02-26%2016%3A56%3A30;


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (32+ messages)  latest in thread

Message-ID: <237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net>
Permalink:  ../237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net/
Also on:    postgresql.org/message-id/237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, peter.eisentraut@enterprisedb.com, juanjo.santamaria@gmail.com, d.koval@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: WIN32 pg_import_system_collations
  In-Reply-To: <237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox