From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: Wed, 22 Dec 2021 09:52:26 -0500
Message-ID: <238201.1640184746@sss.pgh.pa.us> (raw)
In-Reply-To: <YcLYAPsiDlWF6w7o@paquier.xyz>
References: <711370.1639603043@sss.pgh.pa.us>
<20211215212343.GE4440@momjian.us>
<a89d6602-0fad-c6cc-10cc-20105c4c01ad@dunslane.net>
<20211215221310.GU17618@telsasoft.com>
<YbqYuQkoXm8IytZ0@paquier.xyz>
<c7615cf3-621a-7fc4-79ec-6b2554cd5b68@enterprisedb.com>
<E66B93B0-8579-48BC-9CA4-4C6E3A97408D@yesql.se>
<20211217172113.GL17618@telsasoft.com>
<YcBnT2awK89o6P5I@paquier.xyz>
<20211221033926.GX17618@telsasoft.com>
<YcLYAPsiDlWF6w7o@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 20, 2021 at 09:39:26PM -0600, Justin Pryzby wrote:
>> Are you suggesting to remove these ?
>> -/pg_upgrade_internal.log
>> -/loadable_libraries.txt
> Yep, it looks so as these are part of the logs, the second one being a
> failure state.
>> -/reindex_hash.sql
> But this one is not, no?
I'd like to get to a state where there's just one thing to "rm -rf"
to clean up after any pg_upgrade run. If we continue to leave the
we-suggest-you-run-these scripts loose in $CWD then we've not really
improved things much.
Perhaps there'd be merit in putting log files into an additional
subdirectory of that output directory, like
pg_upgrade_output.d/logs/foo.log, so that the more-ignorable
output files would be separated from the less-ignorable ones.
Or perhaps that's just gilding the lily.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pryzby@telsasoft.com, daniel@yesql.se, peter.eisentraut@enterprisedb.com, andrew@dunslane.net, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade should truncate/remove its logs before running
In-Reply-To: <238201.1640184746@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox