pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Piotr Stefaniak <postgres@piotr-stefaniak.me>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
Date: Sun, 19 May 2019 14:13:09 -0400
Message-ID: <2436.1558289589@sss.pgh.pa.us> (raw)
In-Reply-To: <DB8PR03MB59312BBC57C0B8D8C10DD3E1F2050@DB8PR03MB5931.eurprd03.prod.outlook.com>
References: <CAEepm=0P3FeTXRcU5B2W3jv3PgRVZ-kGUXLGfd42FFhUROO3ug@mail.gmail.com>
	<7659.1548653310@sss.pgh.pa.us>
	<20190128070842.GF15401@paquier.xyz>
	<CAEepm=0UtAPN2RChs7=pOqHm2uvbU6Px7vfyvt8_-eiP7=ozUg@mail.gmail.com>
	<CA+hUKGKCvoUsU_HpW+hg8WNDUFjQEgQvVi9AwYdsqgJfV8TzxQ@mail.gmail.com>
	<14259.1557895390@sss.pgh.pa.us>
	<9170.1557955021@sss.pgh.pa.us>
	<CA+hUKGKb9n8xgWW3uEiA3Txvb9Er-FRX-wAAiiWdAjD7-nN44Q@mail.gmail.com>
	<17265.1557955842@sss.pgh.pa.us>
	<16886.1558104483@sss.pgh.pa.us>
	<DB8PR03MB59315C886E551B2D4483099FF2050@DB8PR03MB5931.eurprd03.prod.outlook.com>
	<32165.1558286841@sss.pgh.pa.us>
	<DB8PR03MB59312BBC57C0B8D8C10DD3E1F2050@DB8PR03MB5931.eurprd03.prod.outlook.com>

Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 19/05/2019 19.27, Tom Lane wrote:
>> Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
>>> I think it's safe to assume that upstream can drop support for K&R-style
>>> parameters altogether.

>> Cool.  I already created the switch, but maybe we could have it
>> default to -nkr?

> Sorry, but GNU indent already uses -kr for something else and I would 
> like FreeBSD indent have something like that under the same name. 
> Besides, indent has too many options and this one doesn't look like 
> particularly desired by anyone. It's possible that someone will complain 
> some day, but I don't think we should assume that they'll do or that 
> they're more important than the other users who benefit from your change 
> being the default behavior and no additional options.

Huh.  OK, I'll rip the switch back out again.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <2436.1558289589@sss.pgh.pa.us>
Permalink:  ../2436.1558289589@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2436.1558289589@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, postgres@piotr-stefaniak.me, thomas.munro@gmail.com, michael@paquier.xyz
  Subject: Re: Emacs vs pg_indent's weird indentation for function declarations
  In-Reply-To: <2436.1558289589@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox