pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Cédric Villemain <cedric@2ndquadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Fri, 11 Oct 2013 12:34:23 +0200
Message-ID: <2449747.BOTx2DZ99o@obelix> (raw)
In-Reply-To: <1381455444.5264.16.camel@vanquo.pezone.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
	<52536737.7060006@dunslane.net>
	<1381455444.5264.16.camel@vanquo.pezone.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Le jeudi 10 octobre 2013 21:37:24 Peter Eisentraut a écrit :
> On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote:
> > The code has been sitting in HEAD for several months, and I
> > committed on the back branches because it was wanted.
> 
> New features normally go through a full development cycle including
> extensive beta testing, especially when they contain changes to
> external interfaces.  The fact that the patch author wanted his
> feature released immediately (of course) doesn't warrant a free pass
> in this case, IMO.

What's new feature ?

PGXS break when 19e231b was commited, the patch around this special 
submake is trying to bugfix that.
See http://www.postgresql.org/message-id/201305281410.32535.cedric@2ndquadrant.com


There are also reports like this one (and thread):
http://www.postgresql.org/message-id/CABRT9RCJ6RvgMXbyebCgYMwBwiOBKO_W6zvwrzn75_f+USpQ5g@mail.gmail....

where you can read that I am not 'the' only guy who want to have this 
commited. And believeing this is worth a backpatch as it stands for a 
bugfix.

Here also the problem is stated as something to fix.

http://www.postgresql.org/message-id/20130516165318.GF15045@eldon.alvh.no-ip.org

That's being said, you are correct about the problem you found and it's 
good to be able to release new version without a bug for OSX.
I'm just sad you didn't get time to voice a bit before Andrew spent too 
much time on that.
-- 
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

Attachments:

  signature.asc (application/pgp-signature, 489B) download

view thread (68+ messages)  latest in thread

Message-ID: <2449747.BOTx2DZ99o@obelix>
Permalink:  ../2449747.BOTx2DZ99o@obelix/
Also on:    postgresql.org/message-id/2449747.BOTx2DZ99o@obelix

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: cedric@2ndquadrant.com, peter_e@gmx.net, andrew@dunslane.net, josh@agliodbs.com, robertmhaas@gmail.com, craig@2ndquadrant.com
  Subject: Re: Bugfix and new feature for PGXS
  In-Reply-To: <2449747.BOTx2DZ99o@obelix>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox