From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Mon, 07 Oct 2013 22:00:23 -0400
Message-ID: <52536737.7060006@dunslane.net> (raw)
In-Reply-To: <1381193255.25702.4.camel@vanquo.pezone.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
<51DB171F.2090108@dunslane.net>
<201307122350.23726.cedric@2ndquadrant.com>
<1739933.FyLmpy7Q73@obelix>
<5248B32E.1090001@dunslane.net>
<1381193255.25702.4.camel@vanquo.pezone.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote:
>> On 09/03/2013 04:04 AM, Cédric Villemain wrote:
>>>> Simple one, attached.
>>>> I didn't document USE_VPATH, not sure how to explain that clearly.
>>> Just a remember that the doc is written and is waiting to be commited.
>>>
>>> There is also an issue spoted by Christoph with the installdirs prerequisite,
>>> the attached patch fix that.
>>>
>> I applied this one line version of the patch, which seemed more elegant
>> than the later one supplied.
>>
>> I backpatched that and the rest of the VPATH changes for extensiuons to
>> 9.1 where we first provided for extensions, so people can have a
>> reasonably uniform build system for their extensions.
> I suspect this line
>
> submake-libpq: $(libdir)/libpq.so ;
>
> will cause problems on platforms with a different extension (e.g. OS X).
>
> Given that this supposedly small and noninvasive set of changes has
> caused a number of problems already, I suggest we revert this entire
> thing until we have had time to actually test it somewhere other than in
> the the stable branches. As it stands, it is a new feature being
> developed in the stable branches, which is clearly not acceptable.
If you want to revert it then go ahead, but the last statement is simply
incorrect. The code has been sitting in HEAD for several months, and I
committed on the back branches because it was wanted.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, peter_e@gmx.net, josh@agliodbs.com, robertmhaas@gmail.com, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <52536737.7060006@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox