pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A few warnings on Windows
Date: Wed, 02 May 2018 16:01:53 -0400
Message-ID: <26334.1525291313@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=05qF_Sq80oVsk53mvCO3KNSVK8Dt5VCnB5LHkQjh9ejQ@mail.gmail.com>
References: <CAEepm=3=TDYEXUEcHpEx+Twc31wo7PA0oBAiNt6sWmq93MW02A@mail.gmail.com>
	<20180501083026.GB25848@paquier.xyz>
	<15083.1525207729@sss.pgh.pa.us>
	<CAEepm=2AQxJENLfhZzU-=AcxmHXbDXV=kEdzPh7hjQrmmuHxWQ@mail.gmail.com>
	<CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
	<26880.1525217953@sss.pgh.pa.us>
	<CAEepm=1vo7zUaAvHcRnLieNQ2rbqDDoyjDXxWxJF_aUfWCY8Lg@mail.gmail.com>
	<CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>
	<18264.1525235334@sss.pgh.pa.us>
	<CAEepm=05qF_Sq80oVsk53mvCO3KNSVK8Dt5VCnB5LHkQjh9ejQ@mail.gmail.com>

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> The only remaining warnings on those machines now come from the fact
> that our port_win32.h and Perl's XSUB.h both want to define macros to
> define macros for libc functions like mkdir etc.  plperl.h already
> seems to deal with other similar kinds of ugliness.  Perhaps if
> PG_NEED_PERL_XSUB_H is defined we should undefine port_win32.h's
> libc-stealing macros before including it?  Either way XSUB.h's
> definitions win.  That should get us to 0 warnings.  See attached (not
> tested).

Seems reasonable to me.  Pushed, we'll see what the buildfarm thinks.

			regards, tom lane




view thread (21+ messages)  latest in thread

Message-ID: <26334.1525291313@sss.pgh.pa.us>
Permalink:  ../26334.1525291313@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/26334.1525291313@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, michael@paquier.xyz
  Subject: Re: A few warnings on Windows
  In-Reply-To: <26334.1525291313@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox