From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: [RFC] building postgres with meson - v12
Date: Wed, 7 Sep 2022 07:10:37 +0200
Message-ID: <2679face-90c2-d031-01f5-dfadac710d6f@enterprisedb.com> (raw)
In-Reply-To: <20220902165723.yi2d7jf6mhc4k2dd@awork3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
<20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
<2180a97c-c026-1b6c-cec8-d6e499f97017@enterprisedb.com>
<20220831181154.ebqkjahjzs5bttfa@awork3.anarazel.de>
<CAFBsxsHOpxGeh0z8S5T3rOdHyvObZw89sqD+h_VNmfMJ6DOGbA@mail.gmail.com>
<20220902163515.vonnesmbu6lsissq@awork3.anarazel.de>
<20220902165723.yi2d7jf6mhc4k2dd@awork3.anarazel.de>
On 02.09.22 18:57, Andres Freund wrote:
> Is it worth running ninja -t missingdeps as a test? At the time we run tests
> we'll obviously have built and thus collected "real" dependencies, so we would
> have the necessary information to determine whether dependencies are missing.
> I think it'd be fine to do so only for ninja >= 1.11, rather than falling back
> to the llvm python implementation, which is much slower (0.068s vs
> 3.760s). And also because it's not as obvious how to include the python script.
>
> Alternatively, we could just document that ninja -t missingdeps is worth
> running. Perhaps at the top of the toplevel build.meson file?
In the GNU/make world there is a distinction between "check" and
"maintainer-check" for this kind of thing.
I think here if we put these kinds of things into a different, what's
the term, "suite", then that would be a clear way to collect them and be
able to run them all easily.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de, john.naylor@enterprisedb.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v12
In-Reply-To: <2679face-90c2-d031-01f5-dfadac710d6f@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox